RFR: 8319244: implement JVMTI handshakes support for virtual threads [v8]
Serguei Spitsyn
sspitsyn at openjdk.org
Sat Nov 18 14:38:30 UTC 2023
On Sat, 18 Nov 2023 01:37:21 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review: add jdk_internal_vm_Continuation::done(cont) check to JvmtiEnvBase::is_vthread_alive
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 631:
>
>> 629: return !jdk_internal_vm_Continuation::done(cont) &&
>> 630: java_lang_VirtualThread::state(vt) != java_lang_VirtualThread::NEW &&
>> 631: java_lang_VirtualThread::state(vt) != java_lang_VirtualThread::TERMINATED;
>
> AFAIU `jdk_internal_vm_Continuation::done(cont)` is correct check that vthread is terminated and works for both mounted and unmounted vthreads.
> Then `java_lang_VirtualThread::state(vt) != java_lang_VirtualThread::TERMINATED` check is not needed
Good suggestion, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16460#discussion_r1398219250
More information about the hotspot-dev
mailing list