RFR: 8319973: AArch64: Save and restore FPCR in the call stub

Thomas Stuefe stuefe at openjdk.org
Mon Nov 20 15:40:48 UTC 2023


On Mon, 13 Nov 2023 18:18:35 GMT, Andrew Haley <aph at openjdk.org> wrote:

> On AArch64 we don't save and restore the default floating-point control state when we enter and leave Java code. We really should, because if we're called via the JNI invocation interface with a weird FP control state we'll not be Java compatible.

Looks good, one question inline.

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 145:

> 143:   //      ...
> 144:   // -29 [ argument word 1      ]
> 145:   // -28 [ saved Floating-point Control Register ]

Why the 1-word gap? Alignment?

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16637#pullrequestreview-1740119235
PR Review Comment: https://git.openjdk.org/jdk/pull/16637#discussion_r1399385258


More information about the hotspot-dev mailing list