RFR: 8318159: RISC-V: Improve itable_stub [v2]

[Yuri Gaevsky]

On Thu, 16 Nov 2023 04:42:07 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Yuri Gaevsky has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments from @RealFYang and @robehn.
>
> Changes requested by fyang (Reviewer).

@RealFYang and @robehn: thanks for your reviews, I've updated the patch as you suggested.

> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2562:
> 
>> 2560:   mv(holder_offset, zr);
>> 2561:   // scan_temp = &(itable[0]._interface)
>> 2562:   la(scan_temp, Address(scan_temp));
> 
> The `la` call here won't emit any instructions [1]. So I think we can simply remove it and apply the code comment at L2561 to the preceding `shadd` call.
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L745

Good catch, thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16657#issuecomment-1819376231
PR Review Comment: https://git.openjdk.org/jdk/pull/16657#discussion_r1399441672