RFR: 8318159: RISC-V: Improve itable_stub [v2]

Yuri Gaevsky duke at openjdk.org
Mon Nov 20 16:20:57 UTC 2023


On Mon, 20 Nov 2023 08:50:08 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Yuri Gaevsky has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments from @RealFYang and @robehn.
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2548:
> 
>> 2546:   int itmentry_off_bytes = in_bytes(itableMethodEntry::method_offset());
>> 2547:   int vte_size_bytes = vtableEntry::size_in_bytes();
>> 2548:   const int vte_scale = 3;
> 
> exact_log2(vtableEntry::size_in_bytes())

Done.

> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2557:
> 
>> 2555:   //                            + sizeof(vtableEntry) * (recv_klass->_vtable_len);
>> 2556:   // temp_itbl_klass = itable[0]._interface;
>> 2557:   assert(vte_size_bytes == wordSize, "else adjust vte_scale");
> 
> exact_log2 have assert so you can then remove this one.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16657#discussion_r1399442791
PR Review Comment: https://git.openjdk.org/jdk/pull/16657#discussion_r1399442342


More information about the hotspot-dev mailing list