RFR: 8320278: ARM32 build is broken after JDK-8301997

[Coleen Phillimore]

On Mon, 20 Nov 2023 20:37:23 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> JDK-8301997 changed the handling of constant pool cache entries for methods and fully removed the ConstantPoolCacheEntry class. This commit included changes to the interpreters for all supported platforms except ARM32, and its omission resulted in a GHA failure. This patch intends to introduce an ARM32 port that reflects the code changes to the included platforms so the ARM32 code can build and thus pass testing. Verified with tier 1-4 tests.

This looks good.  This should help the arm32 porters get started and fix the compilation errors.  I think in the description, you meant to say you ran tier1-4 on Oracle platforms not arm32.

src/hotspot/cpu/arm/templateTable_arm.cpp line 2584:

> 2582:       __ add(Rtemp, Rcache, in_bytes(ResolvedMethodEntry::bytecode1_offset()));
> 2583:     case f2_byte:
> 2584:       __ add(Rtemp, Rcache, in_bytes(ResolvedMethodEntry::bytecode2_offset()));

this is missing breaks.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16749#pullrequestreview-1740795581
PR Review Comment: https://git.openjdk.org/jdk/pull/16749#discussion_r1399815942