RFR: 8314220: Configurable InlineCacheBuffer size [v3]

[Dean Long]

On Mon, 20 Nov 2023 22:19:50 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> InlineCacheBuffer size is currently hardcoded to 10K.
>> This can lead to multiple ICBufferFull safepoints for InlineCacheBuffer cleanup and possible performance degradation.
>> 
>> Added experimental command line option InlineCacheBufferSize with the same default value, allowing it to be configured for performance experiments with ICBufferFull safepoints frequency.
>
> Ekaterina Vergizova has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed type, removed unnecessary guarantees

Marked as reviewed by dlong (Reviewer).

This looks good.  There is still potentially over-alignment for the data header, but that's an existing problem:

65    // ICStub_from_destination_address looks up Stub* address from code entry address,
66    // which unfortunately means the stub head should be at the same alignment as the code.
67    static  int alignment()                        { return CodeEntryAlignment; }

I suggest you get another review before integrating.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15271#pullrequestreview-1740880822
PR Comment: https://git.openjdk.org/jdk/pull/15271#issuecomment-1819987260