RFR: 8314220: Configurable InlineCacheBuffer size [v3]

Dean Long dlong at openjdk.org
Tue Nov 21 01:31:11 UTC 2023


On Tue, 21 Nov 2023 00:22:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ekaterina Vergizova has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed type, removed unnecessary guarantees
>
> src/hotspot/share/code/stubs.cpp line 221:
> 
>> 219:   // verify alignment
>> 220:   guarantee(_buffer_size  % stub_alignment() == 0, "_buffer_size  not aligned");
>> 221:   guarantee(_buffer_limit % stub_alignment() == 0, "_buffer_limit not aligned");
> 
> Why these were removed?

I suggested to remove it, because it shouldn't be necessary to align the end of the code.  Only the data header and code start should need alignment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15271#discussion_r1399925678


More information about the hotspot-dev mailing list