RFR: 8320418: PPC64: invokevfinal_helper duplicates code to handle ResolvedMethodEntry

Martin Doerr mdoerr at openjdk.org
Tue Nov 21 10:01:08 UTC 2023


On Tue, 21 Nov 2023 08:24:08 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> One is a copy of the other. See usages of `method_entry->fill_in` in src/hotspot/share/oops/cpCache.cpp. E.g.
>> `method_entry->fill_in((u1)as_TosState(method->result_type()), (u2)method()->size_of_parameters());`
>> Scaling happens in `load_receiver`.
>
> Thanks for looking it up for me :)
> So `ResolvedMethodEntry::_number_of_parameters` is a misnomer or am I missing something?

Well, the size in stack words is the same as the number. One can like it or not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16741#discussion_r1400314203


More information about the hotspot-dev mailing list