RFR: 8320418: PPC64: invokevfinal_helper duplicates code to handle ResolvedMethodEntry

Richard Reingruber rrich at openjdk.org
Tue Nov 21 11:36:11 UTC 2023


On Mon, 20 Nov 2023 15:40:10 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> `TemplateTable::invokevfinal_helper` should use `TemplateTable::prepare_invoke`. `TemplateInterpreter::invoke_return_entry_table_for` needs to support `_fast_invokevfinal` bytecode for that which is only used by PPC64. (It is probably still beneficial for AIX which doesn't support CDS.)
> In addition, I've cleaned up some inaccurate comments.

Looks good (apart from the preexisting misnomer `ResolvedMethodEntry::_number_of_parameters`).

-------------

Marked as reviewed by rrich (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16741#pullrequestreview-1741762882


More information about the hotspot-dev mailing list