RFR: 8257076: os::scan_pages is empty on all platforms

David Holmes dholmes at openjdk.org
Wed Nov 22 01:14:02 UTC 2023


On Mon, 20 Nov 2023 15:20:33 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> The function os::scan_pages was only ever implemented in Solaris and then removed in [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224)
> 
> All other platforms have empty implementations and the interface is not optimal as os::scan_pages expects the range to have just one page size, while in reality it can have multiple. 
> 
> This PR removes this interface, ensuing empty implementations and all dead code related to page scanning.
> 
> Testing: Tier 1.

Yes that all looks like dead code. Nice cleanup. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16740#pullrequestreview-1743397861


More information about the hotspot-dev mailing list