RFR: JDK-8320382: Remove CompressedKlassPointers::is_valid_base()

[Thomas Stuefe]

On Tue, 21 Nov 2023 17:48:06 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> I think it's ok. I think there is an advantage in checking the base early instead of somewhere deep in MA, at which point I'd probably wonder where the base came from. Maybe there is a way to achieve the simplification that you had in mind while also retaining those checks?

Honestly, none that is worth the complexity. These asserts usually fired as a result of metaspace reservation - which is an automatic process - coming up with unsuitable reservation addresses. An assert at that point is every bit as baffling to the end user as the later assert in MA. The only point where an early clear warning makes sense is when we check the user input for SharedBaseAddress, which we do (and, the new message is even better than the old one).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16727#issuecomment-1822157463