RFR: 8319797: Recursive lightweight locking: Runtime implementation [v6]

Daniel D. Daugherty dcubed at openjdk.org
Wed Nov 22 21:36:12 UTC 2023


On Wed, 22 Nov 2023 17:24:22 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge remote-tracking branch 'upstream_jdk/pr/16603' into JDK-8319797
>>  - Merge remote-tracking branch 'upstream_jdk/pr/16603' into JDK-8319797
>>  - Merge remote-tracking branch 'upstream_jdk/pr/16603' into JDK-8319797
>>  - Fix nit
>>  - Fix comment typos
>>  - 8319797: Recursive lightweight locking: Runtime implementation
>
> src/hotspot/share/runtime/synchronizer.cpp line 498:
> 
>> 496:                p2i(monitor->owner()), p2i(current), monitor->object()->mark_acquire().value());
>> 497:         assert(!lock_stack.is_full(), "must have made room here");
>> 498:       }
> 
> This is an interesting idea. I'll have to see how you test this code later on...

Update: I didn't see an explicit test case for overflowing the lock stack.
Do you plan to add one?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16606#discussion_r1402697309


More information about the hotspot-dev mailing list