RFR: 8320347: Emulate vblendvp[sd] on ECore [v2]

[Volodymyr Paprotski]

On Tue, 21 Nov 2023 17:48:30 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 3577:
>> 
>>> 3575:   if (EnableX86ECoreOpts && scratch_available && dst_available) {
>>> 3576:     XMMRegister full_mask = mask;
>>> 3577:     if (!fully_masked) {
>> 
>> name change suggestion for better understanding. fully_masked -> compute_mask
>
> We can also remove full_mask register and directly update mask if compute mask is true.

> name change suggestion for better understanding. fully_masked -> compute_mask

Done. Also had to flip the boolean to default true and update all the call-sites (I like the new name, but don't like that the default is true..)

> We can also remove full_mask register and directly update mask if compute mask is true.

Good point, fixed (I keep on thinking of the parameters as pass-by-reference, don't touch... but its a copy.. lots of copy-construction..)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1402816131