RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry

[David Holmes]

On Tue, 21 Nov 2023 16:38:14 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> ResolvedMethodEntry::reset_entry() clears the fields in the structure and then restores the constant pool index and the resolved references index if it has one. Currently, the resolved references index is restored without restoring the has_resolved_reference flag used by the structure. 
> 
> This patch restored the flag with the resolved references index. Verified with tier 1-5 tests.

Change seems fine but what was the effect of not restoring the flag? Does this cause failures or just unnecessary re-resolution, or?

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16769#pullrequestreview-1745736845