RFR: JDK-8320368: Per-CPU optimization of Klass range reservation [v6]
Thomas Stuefe
stuefe at openjdk.org
Thu Nov 23 06:28:29 UTC 2023
On Thu, 23 Nov 2023 05:07:45 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove stray newline
>
> src/hotspot/cpu/riscv/compressedKlass_riscv.cpp line 41:
>
>> 39: //
>> 40: // A "good" base is, in this order:
>> 41: // 1) only bits in A; this would be an address < 2KB, which is unrealistic on normal Linux boxes since
>
> @tstuefe : Hi Thomas, thanks for considering riscv. A small question: is the`2KB` in the code comment a typo? Seems that it should be `4KB` instead :-)
Oh, you are right, thanks for catching that!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16743#discussion_r1402954055
More information about the hotspot-dev
mailing list