RFR: JDK-8320383: refresh libraries cache on AIX in VMError::report [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Nov 23 15:16:13 UTC 2023
On Thu, 23 Nov 2023 14:46:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> VMError::report outputs information about loaded shared libraries; but this info could be outdated on AIX because the libraries cache is currently not refreshed before printing.
>> This is similar to [JDK-8318587](https://bugs.openjdk.org/browse/JDK-8318587) .
>> The refresh in VMError::report could be omitted in some situations where the refresh call is considered problematic.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> use new method also in print_vm_info
Good!
src/hotspot/share/utilities/vmError.cpp line 727:
> 725: if (should_report_bug(_id)) {
> 726: os::prepare_native_symbols();
> 727: }
Ugh, misuse of "should report bug" as "is oom error" :-/ But no problem, I see you just repeat the existing pattern, that is fine. We can clean that in a separate patch.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16730#pullrequestreview-1746656316
PR Review Comment: https://git.openjdk.org/jdk/pull/16730#discussion_r1403508964
More information about the hotspot-dev
mailing list