RFR: 8320347: Emulate vblendvp[sd] on ECore [v2]

Jatin Bhateja jbhateja at openjdk.org
Thu Nov 23 19:12:23 UTC 2023


On Wed, 22 Nov 2023 17:27:16 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorization/TestSignumVector.java line 112:
>> 
>>> 110:             if (fout[i] != 1.0)   throw new RuntimeException("Expected positive numbers in second half of array: " + java.util.Arrays.toString(fout));
>>> 111:         }
>>> 112:     }
>> 
>> Its ok to add correctness check here, but test only intend to perform check IR validations, there are detailed function tests in following files
>> test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
>> test/hotspot/jtreg/compiler/c2/cr6340864/TestFloatVect.java
>> test/hotspot/jtreg/compiler/c2/cr6340864/TestDoubleVect.java
>
> I am ok to remove this change to the test.. I didn't know where the other tests where and by the time I did find those, already added this. (Figured "more test === good", but its just duplicate)

I am fine with it. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1403637285


More information about the hotspot-dev mailing list