RFR: 8318217: RISC-V: C2 VectorizedHashCode [v2]
Hamlin Li
mli at openjdk.org
Fri Nov 24 18:44:09 UTC 2023
On Thu, 23 Nov 2023 08:19:04 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Done in [this commit](https://github.com/openjdk/jdk/pull/16629/commits/af940acd365677ec3c29a8f066b68b753ad362e4). I've tried the usage of iRegP/iRegI but that caused of the related failure (JVM even didn't start).
>
> I guess it might be a performance consideration (maybe saving some register-register moves?). I see the x86_64 counterpart also specifies certain regsiters [1]. You might want give it try on x86_64 to find out how it may make a difference on the JIT code.
>
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86_64.ad#L11225
Hey, I saw you already change the code in this patch to not use the specific registers, do you still face the JVM starting issue?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1404588307
More information about the hotspot-dev
mailing list