RFR: 8318227: RISC-V: C2 ConvHF2F

Sat Nov 25 02:25:05 UTC 2023

On Sat, 25 Nov 2023 02:20:12 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> And at the other side, the nan processing code is almost the same size as trampoline calling code, is it worth to do it in this case?
>> 
>> Although I can image in another patch for floatToFloat16, it's worth to give it a try by using a out-of-line stub, as in that case, the nan processing a bit longer than float16ToFloat (i.e. this patch).
>
> You can take a look at x86 implementation of ConvF2I node which takes advantages of a general stub mechanism in C2.

https://github.com/openjdk/jdk/blob/6aa197667ad05bd93adf3afc7b06adbfb2b18a22/src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp#L4307

Note that the stub will still reside in the code section of the current method, is a trampoline needed in that case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16802#discussion_r1404704954