RFR: JDK-8320383: refresh libraries cache on AIX in VMError::report [v3]
Thomas Stuefe
stuefe at openjdk.org
Mon Nov 27 06:28:15 UTC 2023
On Thu, 23 Nov 2023 14:46:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> VMError::report outputs information about loaded shared libraries; but this info could be outdated on AIX because the libraries cache is currently not refreshed before printing.
>> This is similar to [JDK-8318587](https://bugs.openjdk.org/browse/JDK-8318587) .
>> The refresh in VMError::report could be omitted in some situations where the refresh call is considered problematic.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> use new method also in print_vm_info
> This one slipped past me and I don't like it. This is an AIX specific change masquerading as a general operation but it is not needed on any platform but AIX.
>
> > Otherwise, I'd be in favor of finding a reasonable OS abstraction for this.
>
> @Stuefe this is the opposite to what you suggested for the AIX specific changes for static library loading. It was proposed there to implement an os abstraction and you rightly said no because it was an AIX only issue. I don't see this is any different.
>
@dholmes-ora The reason I proposed this is that on Windows, we have code paths that are executed on demand on symbol decoding. Its exactly the same thing as on AIX: we need to refresh the loaded pdb list. This would fit well into this abstraction.
The ElfDecoder opens the dwarf file for sourceinfo on the first query. Again, would fit here.
Every decoding mechanism that needs setup could use this dedicated setup routine instead of doing it on demand when the first query happens.
> And I have to ask why are we suddenly seeing so many of these issues with AIX? Has it recently undergone some major changes that now make it incompatible with a lot of our shared code? Or have "we" just not cared about these issues in the past.
Both IBM and SAP stepped up their AIX efforts because the AIX port is still needed. More eyes find more issues.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16730#issuecomment-1827192938
More information about the hotspot-dev
mailing list