RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object [v5]

Stefan Karlsson stefank at openjdk.org
Mon Nov 27 09:44:09 UTC 2023


On Mon, 27 Nov 2023 02:09:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Split test and use othervm
>
> test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/GetOwnedMonitorInfoTest.java line 58:
> 
>> 56:         // Inject this situation into this test that performs other
>> 57:         // GetOwnedMonitorInfo testing.
>> 58:         Object obj = new Object() { public String toString() {return "";} };
> 
> Nit: the `toString` definition is not needed. This could just be `new Object();`, or `new Object() {};` if you want to introduce a nested class.

Thanks. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1405891539


More information about the hotspot-dev mailing list