RFR: 8320347: Emulate vblendvp[sd] on ECore [v7]
Jatin Bhateja
jbhateja at openjdk.org
Mon Nov 27 15:43:13 UTC 2023
On Mon, 27 Nov 2023 15:19:09 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:
>> src/hotspot/cpu/x86/x86.ad line 7821:
>>
>>> 7819:
>>> 7820: instruct vblendvpFD(legVec dst, legVec src1, legVec src2, legVec mask) %{
>>> 7821: predicate(UseAVX > 0 && !EnableX86ECoreOpts &&
>>
>> Why do you not call newly added macro assembly routine to emulate vblendvps from instruction encoding, we already have EnableX86ECoreOpts checks within it.
>
> I would have to change the effect to give myself a temp for the scratch register.. Seems safer not to change existing behaviour.
That should be fine, lets not penalize getting perf improvement due to additional temp.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1406356724
More information about the hotspot-dev
mailing list