RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v10]

[Kim Barrett]

On Mon, 27 Nov 2023 17:52:05 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> src/hotspot/share/oops/symbolHandle.hpp line 115:
>> 
>>> 113:   }
>>> 114: 
>>> 115:   static void drain_cleanup_delay_queue() {
>> 
>> It's not obvious that draining the queue is useful. Unless there's a reason I'm missing, I suggest not doing so.
>
> I don't feel too strongly either way but someone else previously suggested draining during the periodic task so I added it.
> The benefit is not leaving Symbols hanging around in the queue indefinitely (though granted, a fixed number of them, so the memory waste is limited). The downside is a small piece of added code and work on the periodic task.

I didn't find any discussion of whether draining is needed in this PR, and draining is in the initial commit.
Other downsides include the need to test that feature and the impact that feature has on testing other parts
of this change.  Unless someone argues for it, I'd prefer to see it removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1406864079