RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v4]

[Coleen Phillimore]

On Wed, 1 Nov 2023 13:29:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> test/hotspot/gtest/classfile/test_placeholders.cpp line 46:
>> 
>>> 44:   Symbol* super = SymbolTable::new_symbol("super2_8_2023_supername");
>>> 45:   Symbol* interf = SymbolTable::new_symbol("interface2_8_2023_supername");
>>> 46: 
>> 
>> I swapped these from TempNewSymbol to Symbol before I added the set_cleanup_delay_max_entries functionality to avoid interfering with refcounts in tests.
>> Is the swap safe? Or should I use set_cleanup_delay_max_entries(0) and switch back? I can't tell why some of these were made temp and some not.
>
> I don't remember why they were TempNewSymbol either but I don't think it matters for this test, they can be Symbol*.

I still don't think it matters for the test, but this seems to be an effective workaround.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1406924428