RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v10]

[Coleen Phillimore]

On Tue, 28 Nov 2023 14:23:53 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> I think the footprint savings is probably negligible.  I like the idea that the queue is periodically drained because it might show issues where we've messed up the refcounts, but they'd be hard to debug, so maybe not worth it. So I see neither the harm nor the benefit of draining the queue in the periodic task, but we should have the feature for the one test.
>
> I've removed drain from the concurrent cleanup. I left it public and tested, is that reasonable or do you prefer I make it private somehow (not sure the typical way to have test-only methods)?

I like that there's a test.  Some gtests use friend declarations if they're in a class, but test_symbolTable isn't. I don't think it's worth changing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1408008819