RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v2]

[Ioi Lam]

On Tue, 28 Nov 2023 22:22:22 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> ResolvedMethodEntry::reset_entry() clears the fields in the structure and then restores the constant pool index and the resolved references index if it has one. Currently, the resolved references index is restored without restoring the has_resolved_reference flag used by the structure. 
>> 
>> This patch restored the flag with the resolved references index. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Added asserts to ensure correctness
>  - Merge branch 'master' into resolved_ref_flag
>  - Merge branch 'master' of https://github.com/openjdk/jdk into resolved_ref_flag
>  - 8320530: has_resolved_ref_index flag not restored after resetting entry

LGTM. Just a small nit.

src/hotspot/share/oops/cpCache.cpp line 312:

> 310:   // Store appendix, if any.
> 311:   if (has_appendix) {
> 312:     assert(method_entry->has_resolved_references_index(), "sanity");

The assert is not necessary here, as resolved_references_index() already has the same assert.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16769#pullrequestreview-1754172185
PR Review Comment: https://git.openjdk.org/jdk/pull/16769#discussion_r1408566653