RFR: 8320750: Allow a testcase to run with muliple -Xlog
David Holmes
dholmes at openjdk.org
Wed Nov 29 06:55:07 UTC 2023
On Tue, 28 Nov 2023 08:50:34 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> I have been starting to change test cases to use `createTestJavaProcessBuilder` instead of `createLimitedTestJavaProcessBuilder` because we severely limit our testing when we use `createLimitedTestJavaProcessBuilder`. Before that change there were no way to add `@require` lines for `-X` options. Unfortunately I made a bug when I introduced that functionality.
Sure but I am trying to understand that previous change. I don't speak "stream" so can't figure out what exactly you have done. What I expected you to do was combine the various flags coming in from jtreg arguments and env vars, that would affect the VM under test, then see if that set of args contains the `-X` one the `@requires` refers to. But the added complexity there if actually checking a particular flag value is that you need to know how to combine multiple occurrences of the same arg, the same way that the launcher and/or VM will.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16824#issuecomment-1831316147
More information about the hotspot-dev
mailing list