RFR: JDK-8320892: AArch64: Restore FPU control state after JNI [v3]

Tom Rodriguez never at openjdk.org
Wed Nov 29 16:12:07 UTC 2023


On Tue, 28 Nov 2023 15:58:04 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Some buggy libraries corrupt the floating-point control register. Provide something similar to the x86 RestoreMXCSROnJNICalls. 
>> 
>> I realize that using the x86ish name "RestoreMXCSROnJNICalls" might be a little controversial, but it is a _global_ flag, not a CPU-specific one. And it's clearly intended for this purpose. It might have been better if that flag had been given a better name twentyish years ago, but we can't change it now.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix thinko

x86 also has a restore call in DowncallLinker::StubGenerator::generate so you might consider adding there as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16851#issuecomment-1832210732


More information about the hotspot-dev mailing list