RFR: JDK-8320892: AArch64: Restore FPU control state after JNI [v3]

Wed Nov 29 16:39:05 UTC 2023

On Wed, 29 Nov 2023 16:14:40 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> Regarding the flag name you could introduce a better name and alias to it RestoreMXCSROnJNICalls.

Ah, I did not know that flag aliases were possible. I'll have a look at something generic.

> Reusing the same name it definitely confusing. At a minimum you need to update the documentation for RestoreMXCSROnJNICalls to indicate that it also does something on aarch64 or generalize the language to something like `Restore floating point control word when returning from JNI calls`.

I'll go digging.

> x86 also has a restore call in DowncallLinker::StubGenerator::generate so you might consider adding there as well.

I think it's there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16851#issuecomment-1832295989
PR Comment: https://git.openjdk.org/jdk/pull/16851#issuecomment-1832297313