RFR: 8321025: Enable Neoverse N1 optimizations for Neoverse V2

Aleksey Shipilev shade at openjdk.org
Wed Nov 29 17:29:05 UTC 2023


On Wed, 29 Nov 2023 16:16:12 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

> As Arm Neoverse V2 will benefit from the same optimizations as Neoverse N1 does, it should have OnSpinWaitInst/OnSpinWaitInstCount defaults set to "isb"/1 and UseSIMDForMemoryOps default set to true.
> This patch sets these flags accordingly for the V2 architecture.

Okay in principle, but I have a question, there is another block below:


  // Neoverse V1
  if (_cpu == CPU_ARM && model_is(0xd40)) {
    if (FLAG_IS_DEFAULT(UseCryptoPmullForCRC32)) {
      FLAG_SET_DEFAULT(UseCryptoPmullForCRC32, true);
    }
  }


Should it be enabled for V2 as well?

-------------

PR Review: https://git.openjdk.org/jdk/pull/16887#pullrequestreview-1755841831


More information about the hotspot-dev mailing list