RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v3]

[David Holmes]

On Wed, 29 Nov 2023 20:01:22 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> ResolvedMethodEntry::reset_entry() clears the fields in the structure and then restores the constant pool index and the resolved references index if it has one. Currently, the resolved references index is restored without restoring the has_resolved_reference flag used by the structure. 
>> 
>> This patch restored the flag with the resolved references index. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrections and gtest fix

Thanks for the updates.

One indentation nit to fix before integration please.

src/hotspot/share/oops/resolvedMethodEntry.hpp line 99:

> 97:         _has_interface_klass = false;
> 98:         _has_table_index = false;
> 99: #endif

Indent appears to be 1 instead of 2

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16769#pullrequestreview-1756718722
PR Review Comment: https://git.openjdk.org/jdk/pull/16769#discussion_r1410205566