RFR: 8321025: Enable Neoverse N1 optimizations for Neoverse V2

Evgeny Astigeevich eastigeevich at openjdk.org
Thu Nov 30 11:36:21 UTC 2023


On Wed, 29 Nov 2023 17:54:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> Okay in principle, but I have a question, there is another block below:
>>> 
>>> ```
>>>   // Neoverse V1
>>>   if (_cpu == CPU_ARM && model_is(0xd40)) {
>>>     if (FLAG_IS_DEFAULT(UseCryptoPmullForCRC32)) {
>>>       FLAG_SET_DEFAULT(UseCryptoPmullForCRC32, true);
>>>     }
>>>   }
>>> ```
>>> 
>>> Should it be enabled for V2 as well?
>> 
>> Good catch. I'll check whether V2 has the same or better `pmull` as V1.
>
>> Good catch. I'll check whether V2 has the same or better `pmull` as V1.
> 
> Although, it would not be "enabling N1 optos for V2", it would be "enabling V1 optos for V2" :)
> Your call if you just want to make that change separately.

Thanks @shipilev @nick-arm for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16887#issuecomment-1833588447


More information about the hotspot-dev mailing list