RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v3]

Coleen Phillimore coleenp at openjdk.org
Thu Nov 30 13:42:13 UTC 2023


On Thu, 30 Nov 2023 13:32:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrections and gtest fix
>
> src/hotspot/share/oops/resolvedMethodEntry.hpp line 199:
> 
>> 197: #ifdef ASSERT
>> 198:     _has_interface_klass = true;
>> 199: #endif
> 
> The == false in the asserts looks odd.

This might be more compact (and below), as
DEBUG_ONLY(_has_interface_klass=true);

Same with all of these #ifdef ASSERT blocks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16769#discussion_r1410683618


More information about the hotspot-dev mailing list