RFR: JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library

Matthias Baesken mbaesken at openjdk.org
Thu Nov 30 14:05:17 UTC 2023


On Fri, 17 Nov 2023 08:19:18 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> [JDK-8295159](https://bugs.openjdk.org/browse/JDK-8295159) added some IEEE conformance checks and corrections on Linux and macOS/BSD , however in case of issues no logging is done, this should be improved.
>
> src/hotspot/os/bsd/os_bsd.cpp line 1013:
> 
>> 1011:     int rtn = fesetenv(&default_fenv);
>> 1012:     assert(rtn == 0, "fesetenv must succeed");
>> 1013:     bool ieee_handling_after_issue = IEEE_subnormal_handling_OK();
> 
> This is a misleading name. It should be something explicit like `ieee_handling_succeeded`. Still, I suppose it's too late now.

okay why not ieee_handling_succeeded; I can change the variable name in the follow  up  JDK-8321017 .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16618#discussion_r1410717962


More information about the hotspot-dev mailing list