RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v4]
Coleen Phillimore
coleenp at openjdk.org
Thu Nov 30 18:29:08 UTC 2023
On Thu, 30 Nov 2023 17:31:44 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> ResolvedMethodEntry::reset_entry() clears the fields in the structure and then restores the constant pool index and the resolved references index if it has one. Currently, the resolved references index is restored without restoring the has_resolved_reference flag used by the structure.
>>
>> This patch restored the flag with the resolved references index. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into resolved_ref_flag
> - Coleen comments
> - Corrections and gtest fix
> - Added asserts to ensure correctness
> - Merge branch 'master' into resolved_ref_flag
> - Merge branch 'master' of https://github.com/openjdk/jdk into resolved_ref_flag
> - 8320530: has_resolved_ref_index flag not restored after resetting entry
I think this looks better. thank you!
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16769#pullrequestreview-1758188188
More information about the hotspot-dev
mailing list