RFR: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10 [v4]

[Serguei Spitsyn]

On Thu, 30 Nov 2023 17:48:48 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: remove newly added ThreadsListHandle from enter_interp_only_mode
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 530:
> 
>> 528:   assert(!thread->is_in_tmp_VTMS_transition(), "sanity check");
>> 529: 
>> 530:   // If interp_only_mode is enabled then we must eagerly create JvmtiThreadState
> 
> typo: s/is enabled/has been enabled/

Thanks - fixed now.

> src/hotspot/share/prims/jvmtiThreadState.hpp line 234:
> 
>> 232:   inline void set_head_env_thread_state(JvmtiEnvThreadState* ets);
>> 233: 
>> 234:   static bool _seen_interp_only_mode; // interp_only_mode was requested once
> 
> perhaps: s/requested once/requested at least once/

Thank you - fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16686#discussion_r1411277467
PR Review Comment: https://git.openjdk.org/jdk/pull/16686#discussion_r1411273636