RFR: 8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. [v2]
Yudi Zheng
yzheng at openjdk.org
Wed Oct 4 07:46:35 UTC 2023
On Wed, 4 Oct 2023 07:34:48 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove JVMCIUseFastLocking.
>
> src/hotspot/share/jvmci/jvmci_globals.hpp line 130:
>
>> 128: "Exclude JVMCI compiler threads from benchmark counters") \
>> 129: \
>> 130: develop(bool, JVMCIUseFastLocking, true, \
>
> You should just delete this option - JVMCI is clearly marked as experimental.
> What you have in this PR is not proper deprecation. What if someone specifies `-XX:-JVMCIUseFastLocking`? They will get no warning or VM exit.
Indeed. I have deleted the option.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16032#discussion_r1345341668
More information about the hotspot-dev
mailing list