RFR: 8317761: Combine two versions of print_statistics() in java.cpp [v2]

Ioi Lam iklam at openjdk.org
Tue Oct 10 17:05:12 UTC 2023


> The non-product version of `print_statistics()` can be compiled in the product build as well, so there's no need to keep two different versions.
> 
> BTW, for some reason `print_method_profiling_data()` is called unconditionally in non-product builds, but is guarded by `PrintMethodData` in product builds. I made the behavior the same as before in this PR. This can probably be cleaned up in a future PR.
> 
> I verified that:
> 
> - All functions call by the original product version are also called by the non-product version (but could be in different order).
> - For functions that are called by the non-product version but not call by the original product version: all such calls are guarded by non-product flags (e.g. `TimeOopMap`), or the function itself does nothing (e.g., declared as `PRODUCT_RETURN`)
> 
> Testing: tier1, tier2, build-tiers5

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  call print_method_profiling_data() unconditionally

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16110/files
  - new: https://git.openjdk.org/jdk/pull/16110/files/04376605..f736e91d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16110&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16110&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16110.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16110/head:pull/16110

PR: https://git.openjdk.org/jdk/pull/16110


More information about the hotspot-dev mailing list