Integrated: 8317761: Combine two versions of print_statistics() in java.cpp
Ioi Lam
iklam at openjdk.org
Wed Oct 11 05:14:22 UTC 2023
On Mon, 9 Oct 2023 23:05:26 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The non-product version of `print_statistics()` can be compiled in the product build as well, so there's no need to keep two different versions.
>
> BTW, for some reason `print_method_profiling_data()` is called unconditionally in non-product builds, but is guarded by `PrintMethodData` in product builds. I made the behavior the same as before in this PR. This can probably be cleaned up in a future PR.
>
> I verified that:
>
> - All functions call by the original product version are also called by the non-product version (but could be in different order).
> - For functions that are called by the non-product version but not call by the original product version: all such calls are guarded by non-product flags (e.g. `TimeOopMap`), or the function itself does nothing (e.g., declared as `PRODUCT_RETURN`)
>
> Testing: tier1, tier2, build-tiers5
This pull request has now been integrated.
Changeset: 84b7cc15
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/84b7cc15c20581a14cdd2a590e0a30b1ef9acddb
Stats: 60 lines in 2 files changed: 9 ins; 51 del; 0 mod
8317761: Combine two versions of print_statistics() in java.cpp
Reviewed-by: kvn, vlivanov
-------------
PR: https://git.openjdk.org/jdk/pull/16110
More information about the hotspot-dev
mailing list