RFR: 8315716: RISC-V: implement ChaCha20 intrinsic [v3]

Hamlin Li mli at openjdk.org
Wed Oct 11 07:43:06 UTC 2023


On Tue, 10 Oct 2023 07:29:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Ajust code according round 3 reviewing
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4378:
> 
>> 4376:       chacha20_quarter_round(work_vrs[1], work_vrs[6], work_vrs[11], work_vrs[12], tmp_vr);
>> 4377:       chacha20_quarter_round(work_vrs[2], work_vrs[7], work_vrs[8], work_vrs[13], tmp_vr);
>> 4378:       chacha20_quarter_round(work_vrs[3], work_vrs[4], work_vrs[9], work_vrs[14], tmp_vr);
> 
> I personally prefer to add one extra space to keep the fourth parameter aligned for those calls to `chacha20_quarter_round`.

Thanks for your reviewing!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15899#discussion_r1354318379


More information about the hotspot-dev mailing list