RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v9]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Oct 12 10:41:27 UTC 2023
On Wed, 11 Oct 2023 17:29:11 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to save and restore the floating-point control word around System.loadLibrary(). This isn't perfect, because some shared library might load another shared library at runtime, but it's a lot better than what we do now.
>>
>> However, this fix is not complete. `dlopen()` is called from many places in the JDK. I guess the best thing to do is find and wrap them all. I'd like to hear people's opinions.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>
> Add TestDenormalDouble.java
The latest build changes look trivially good.
(If you decide to make other changes to the build system, please await a re-review of build changes before pushing)
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/10661#pullrequestreview-1673840086
More information about the hotspot-dev
mailing list