RFR: 8318015: Lock inflation not needed for OSR or Deopt for new locking modes [v3]

Martin Doerr mdoerr at openjdk.org
Sat Oct 14 09:46:37 UTC 2023


On Fri, 13 Oct 2023 23:47:43 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Write values into displaced header slots in debug builds.
>
> src/hotspot/share/runtime/basicLock.cpp line 88:
> 
>> 86: #ifdef ASSERT
>> 87:   else {
>> 88:     dest->set_displaced_header(markWord(0xde0bd000)); // eye-catcher
> 
> Such constants for debugging purposes are usually defined in a central place: 
>   https://github.com/openjdk/jdk/blob/master/src/hotspot/share/utilities/globalDefinitions.hpp#L1023
> 
> It makes sense to follow that practice here.

Done. Thanks!
We may remove the displaced header slots and all related code when removing LM_LEGACY.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16165#discussion_r1359288837


More information about the hotspot-dev mailing list