RFR: 8189088: Add intrusive doubly-linked list utility [v7]

Ivan Walulya iwalulya at openjdk.org
Mon Oct 16 11:12:58 UTC 2023


On Mon, 16 Oct 2023 07:58:27 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   const-element nomenclature, other review comments
>
> src/hotspot/share/utilities/intrusiveList.hpp line 994:
> 
>> 992:   const_reference operator[](size_type n) const {
>> 993:     return nth_element(cbegin(), cend(), n);
>> 994:   }
> 
> Do we need these operator[]'s?  Neither std::list nor boost::intrusive::list have such, and I don't think any of the
> existing intrusive lists in HotSpot have such either.  Maybe there's no real use-case.  Removal would save
> 25-30 lines.

If we cannot find a  real use-case for HotSpot, then maybe we shouldn't include them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15896#discussion_r1360496623


More information about the hotspot-dev mailing list