RFR: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo
David Holmes
dholmes at openjdk.org
Wed Oct 18 02:03:42 UTC 2023
On Sat, 7 Oct 2023 17:44:06 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
> In OpenJDK project CRaC I had a [need to fetch new CpuidInfo without affecting the existing one](https://github.com/openjdk/crac/commit/ed4ad9ba31b77732dcede2eb743b2f389ec9a0fe#diff-6ed856c57ddbe33e49883adb7c52ec51ed377e5f697dfd6d8bea505a97bfc5a5R2743).
> Which led me to encapsulate the object more and I think this no-functionality-change patch is even appropriate for JDK.
> I am sure interested primarily to reduce the CRaC patchset boilerplate.
I don't hate this :) but I don't like seeing methods on structs. Should we make `CpuidInfo` a full-fledged class instead?
-------------
PR Review: https://git.openjdk.org/jdk/pull/16093#pullrequestreview-1683769586
More information about the hotspot-dev
mailing list