RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF

Andrew Haley aph at openjdk.org
Wed Oct 18 09:42:20 UTC 2023


On Wed, 18 Oct 2023 08:18:41 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/globals_aarch64.hpp line 131:
>> 
>>> 129:           "Branch Protection to use: none, standard, pac-ret")          \
>>> 130:   product(ccstr, UseSleefLib, "libsleef.so.3", EXPERIMENTAL,            \
>>> 131:           "Sleef library to use for the vector math operations")        \
>> 
>> Experimental functionality like this should not be enabled by default as you are changing the behaviour for all users. This needs to be off by default with user's being able to opt-in if they want.
>
> Sounds reasonable. Thanks a lot for the reminder!

Hard-coding the libsleef ABI version into OpenJDK is a code smell. For now I suppose it'll do, but we need a better strategy going forward, perhaps involving a bundled library.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1363568640


More information about the hotspot-dev mailing list