RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v30]

Volker Simonis simonis at openjdk.org
Thu Oct 19 09:57:44 UTC 2023


On Fri, 13 Oct 2023 01:38:13 GMT, Jonathan Joo <jjoo at openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add call to publish in parallel gc and update counter names

This looks good to me now. I only propose to wait until #16252 will be pushed (it already has two reviews) and than rebase on top of that change and use the generic 64-bit atomics instead of your handcrafted solution. That will remove the need for the clumsy `#ifdef _LP64` code.

Once that is done, I'll approve this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15082#issuecomment-1770469810


More information about the hotspot-dev mailing list