RFR: 8301997: Move method resolution information out of the cpCache [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Oct 19 17:46:20 UTC 2023
On Wed, 18 Oct 2023 15:19:50 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed some comments and relocated code
>
> src/hotspot/share/oops/cpCache.cpp line 335:
>
>> 333: }
>> 334:
>> 335: void ConstantPoolCache::set_method_handle_common(int method_index,
>
> The only place where this method is called is in set_method_handle() just above. Do we really need to have two methods then?
I was also thinking about this after seeing @adinn 's comments. Neither function is private or protected so I think it is safe to just move all of the code from common to `set_method_handle()`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1365906463
More information about the hotspot-dev
mailing list