RFR: 8310239: Add missing cross modifying fence in nmethod entry barriers [v3]

Fri Oct 20 20:55:37 UTC 2023

On Fri, 20 Oct 2023 20:39:42 GMT, Dean Long <dlong at openjdk.org> wrote:

> This looks much better.  Is the cross modify fence always needed, or can it be conditional based on nmethod_patching_type()?

It could be conditional, but the patching type abstraction is currently platform specific, and here we are in shared code. I'm not sure if elevating that to the shared level is worth it, given that I found it not to impact performance. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14543#issuecomment-1773379993