RFR: 8316961: Fallback implementations for 64-bit Atomic::{add,xchg} on 32-bit platforms [v4]
Volker Simonis
simonis at openjdk.org
Mon Oct 23 18:32:30 UTC 2023
On Mon, 23 Oct 2023 14:17:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> See the bug for rationale. Looks like there is enough infrastructure to achieve what we want without significant fan-out. I checked all `atomic_*.hpp` headers for unimplemented `PlatformAdd<8>` and `PlatformXchg<8>`, and only these seem to be affected.
>>
>> Unfortunately, we cannot test these apart from the existing gtest.
>>
>> Additional testing:
>> - [x] linux-x86-server-fastdebug, atomic tests pass
>> - [x] linux-arm-server-fastdebug, atomic tests pass (with #16269 applied)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Use public methods instead of Platform*
Thanks, looks good to me.
-------------
Marked as reviewed by simonis (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16252#pullrequestreview-1693236508
More information about the hotspot-dev
mailing list