RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

[Xiaohong Gong]

On Tue, 24 Oct 2023 09:31:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Disable sleef by default
>>  - Merge 'jdk:master' into JDK-8312425
>>  - 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8496:
> 
>> 8494:     // Get sleef stub routine addresses
>> 8495:     char ebuf[1024];
>> 8496:     void* libsleef = os::dll_load(UseSleefLib, ebuf, sizeof ebuf);
> 
> Shouldn't this check that UseSleefLib has been set to something other than "" ? (To save the failing `dll_load` call.)

Yeah, it's better to do that. Currently it returns "nullptr" without any errors. But I agree that having a pre-check is better. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1370993053